Extract MethodCallReturnTypeHelper from MutatingScope #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
extr1
branch
3 times, most recently
from
d511f17 to
e10e737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor code arround method dynamic return type extensions to allow easier re-use towards phpstan/phpstan#6492 (comment)
no implementation changes - just moving code arround.
additional reducing MutatingScope size is a nice side-effect IMO
as a followup PR I would extract a
FuncCallReturnTypeHelperso we in the end no longer depend onDynamicReturnTypeExtensionRegistryfromMutatingScope.